Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF-1352] Markdown component_map hash improvements #2241

Merged
merged 1 commit into from
Dec 1, 2023
Merged

[REF-1352] Markdown component_map hash improvements #2241

merged 1 commit into from
Dec 1, 2023
+23 −5

Conversation

masenf
Copy link
Collaborator

@masenf masenf commented Dec 1, 2023

  • Hash against the compiled form of each component, not the function that compiles it
  • LRU cache the get_base_component_map function, since that always returns the same thing, no need to recreate the map for every instance of every markdown.
  • Only hash the component map once at create() time

@masenf
[REF-1352] Markdown component_map hash improvements
0eb568b 
* Hash against the compiled form of each component, not the function that compiles it
* LRU cache the `get_base_component_map` function, since that always returns the
  same thing, no need to recreate the map for every instance of every markdown.
* Only hash the component map once at create() time
@picklelo picklelo merged commit eb79da8 into main Dec 1, 2023
45 checks passed
@masenf masenf deleted the masenf/markdown-memo-better branch December 6, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picklelo picklelo picklelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masenf @picklelo